rust-vmm / community

rust-vmm community content
477 stars 26 forks source link

Missing crate owners for `virtio-queue` #155

Closed epilys closed 8 months ago

epilys commented 8 months ago

Running my check_owners.sh script, I get:

virtio-queue
INFO: querying https://crates.io/api/v1/crates/virtio-queue/owners
INFO: API reply was {"users":[{"avatar":"https://avatars.githubusercontent.com/u/2815944?v=4","id":37110,"kind":"user","login":"andreeaflorescu","name":"Andreea Florescu","url":"https://github.com/andreeaflorescu"},{"avatar":"https://avatars.githubusercontent.com/u/511389?v=4","id":50358,"kind":"user","login":"slp","name":"Sergio López","url":"https://github.com/slp"},{"avatar":"https://avatars.githubusercontent.com/u/1931516?v=4","id":82989,"kind":"user","login":"jiangliu","name":"Jiang Liu","url":"https://github.com/jiangliu"},{"avatar":"https://avatars.githubusercontent.com/u/10989787?v=4","id":96953,"kind":"user","login":"alexandruag","name":"Alexandru Agache","url":"https://github.com/alexandruag"},{"avatar":"https://avatars.githubusercontent.com/u/46028664?v=4","id":1481,"kind":"team","login":"github:rust-vmm:gatekeepers","name":"gatekeepers","url":"https://github.com/rust-vmm"}]}
OK: rust-vmm:gatekeepers is an owner.
OK: alexandruag is an owner.
OK: andreeaflorescu is an owner.
OK: jiangliu is an owner.
OK: slp is an owner.
ERROR: stsquad is not an owner.
ERROR: epilys is not an owner.
Missing crate owners for virtio-queue, please add them.

@alexandruag, @andreeaflorescu, @jiangliu, @slp you need to add @stsquad and @epilys as owners.

cargo owner --add stsquad virtio-queue ;
cargo owner --add epilys virtio-queue
andreeaflorescu commented 8 months ago

Invitation sent for @epilys and @stsquad. Please close the issue once you both accept the invitation.

epilys commented 8 months ago

I think we should close it, if invitations were sent they will be accepted.

andreeaflorescu commented 8 months ago

It would be better to close the issue when the invitation is accepted because if the invitation is not accepted in a certain time frame then it expires.

epilys commented 8 months ago

@andreeaflorescu I accepted it, so if @stsquad 's invitation expires I can invite him myself.

Ablu commented 8 months ago

@andreeaflorescu I accepted it, so if @stsquad 's invitation expires I can invite him myself.

Unless we forget it and face the same problems that we face right now :). So I agree with keeping the tickets open as reminder until everyhing is accounted for.

epilys commented 7 months ago

OK, confirmed:

virtio-queue
INFO: querying https://crates.io/api/v1/crates/virtio-queue/owners
INFO: API reply was {"users":[{"avatar":"https://avatars.githubusercontent.com/u/2815944?v=4","id":37110,"kind":"user","login":"andreeaflorescu","name":"Andreea Florescu","url":"https://github.com/andreeaflorescu"},{"avatar":"https://avatars.githubusercontent.com/u/511389?v=4","id":50358,"kind":"user","login":"slp","name":"Sergio López","url":"https://github.com/slp"},{"avatar":"https://avatars.githubusercontent.com/u/8278356?v=4","id":53759,"kind":"user","login":"epilys","name":"Manos Pitsidianakis","url":"https://github.com/epilys"},{"avatar":"https://avatars.githubusercontent.com/u/1931516?v=4","id":82989,"kind":"user","login":"jiangliu","name":"Jiang Liu","url":"https://github.com/jiangliu"},{"avatar":"https://avatars.githubusercontent.com/u/10989787?v=4","id":96953,"kind":"user","login":"alexandruag","name":"Alexandru Agache","url":"https://github.com/alexandruag"},{"avatar":"https://avatars.githubusercontent.com/u/22458?v=4","id":225192,"kind":"user","login":"stsquad","name":"Alex Bennée","url":"https://github.com/stsquad"},{"avatar":"https://avatars.githubusercontent.com/u/46028664?v=4","id":1481,"kind":"team","login":"github:rust-vmm:gatekeepers","name":"gatekeepers","url":"https://github.com/rust-vmm"}]}
OK: rust-vmm:gatekeepers is an owner.
OK: alexandruag is an owner.
OK: andreeaflorescu is an owner.
OK: jiangliu is an owner.
OK: slp is an owner.
OK: stsquad is an owner.
OK: epilys is an owner.