search

rust-vmm / kvm-ioctls

Apache License 2.0
255 stars 103 forks source link

arm64: add support for vCPU SVE feature #228

Closed xuejun-xj closed 11 months ago

xuejun-xj commented 1 year ago

Summary of the PR

This commit add support for initialization of vCPU SVE feature on aarch64:

  1. Add ArmSve in Cap struct.
  2. Add KVM_ARM_VCPU_FINALIZE ioctl in VcpuFd struct, which is used to initialize the finalization of SVE feature for now.
xuejun-xj commented 1 year ago

Hi! This PR adds support for vcpu finalize ioctl. It is used to initialize SVE extention for guest vcpu. Is there anyone help to review this PR?

jiangliu commented 1 year ago

Please also help to change the "CHANGELOG.md" file.

xuejun-xj commented 1 year ago

Please also help to change the "CHANGELOG.md" file.

@jiangliu Thanks for reminder. I have added it in another commit.

roypat commented 11 months ago

Hi @xuejun-xj could you have a look at resolving the conflicts so we can try getting merge before the next release? :o

xuejun-xj commented 11 months ago

Hi @xuejun-xj could you have a look at resolving the conflicts so we can try getting merge before the next release? :o

Thanks, @roypat ! I have found something strange that I have already resolved the conflict and force-pushed to original branch. But this PR page seems nothing changed? It still shows the "Resolve conflicts" button.

image

roypat commented 11 months ago

This is indeed weird - I've seen it happen a few times across different repositories the last few days, so I think GitHub is having some problems recently. Can you try closing this PR and opening a new one from the same branch? That usually fixes it for me :thinking:

xuejun-xj commented 11 months ago

This is indeed weird - I've seen it happen a few times across different repositories the last few days, so I think GitHub is having some problems recently. Can you try closing this PR and opening a new one from the same branch? That usually fixes it for me 🤔

Ok, I will open another PR for #228 .