cap: Skip compiling SetGuestDebug for RISC-V at the moment

rust-vmm / kvm-ioctls

Apache License 2.0

255 stars 103 forks source link

cap: Skip compiling SetGuestDebug for RISC-V at the moment #236

Closed endeneer closed 9 months ago

endeneer commented 9 months ago

RISC-V currently doesn't support KVM_CAP_SET_GUEST_DEBUG.

Summary of the PR

Related: #208 With the conditional compilation, compilation using riscv64gc-unknown-linux-gnu is successful.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

[x] All commits in this PR are signed (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
[N/A] All added/changed functionality has a corresponding unit/integration test.
[N/A] All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).
[N/A] Any newly added unsafe code is properly documented.

rbradford commented 9 months ago

@andreeaflorescu Will the merge commit go away when "Rebase & merge" is pressed? I never know as it's not part of my usual workflow.

andreeaflorescu commented 9 months ago

@andreeaflorescu Will the merge commit go away when "Rebase & merge" is pressed? I never know as it's not part of my usual workflow.

Yes, that's why I am using it because it keeps the approvals at no cost.

andreeaflorescu commented 9 months ago

@rbradford the reason why that goes away is because the merge strategy for PRs is rebase & merge. You can see that no rebase commit was added when I merged this: https://github.com/rust-vmm/kvm-ioctls/commits/main

rbradford commented 9 months ago

@rbradford the reason why that goes away is because the merge strategy for PRs is rebase & merge. You can see that no rebase commit was added when I merged this: https://github.com/rust-vmm/kvm-ioctls/commits/main

Cool, I thought that would happen - I guess the only time the merge commit would stay around is if it contained changes to resolve a merge conflict - and that is not something that the would happen with the web ui update branch button.

andreeaflorescu commented 9 months ago

Cool, I thought that would happen - I guess the only time the merge commit would stay around is if it contained changes to resolve a merge conflict - and that is not something that the would happen with the web ui update branch button.

yap, that's true!