search

rust-vmm / kvm

283 stars 109 forks source link

Add the ioctls used by CrosVM #11

Closed andreeaflorescu closed 4 years ago

andreeaflorescu commented 5 years ago

To be scoped.

MrXinWang commented 4 years ago

Hi @andreeaflorescu !

For aarch64 platform, there are currently 6 ioctls in CrosVM which are not included in rust-vmm, namely:

Among these 6 ioctls, only the first two ioctls (KVM_IRQ_LINE and KVM_SET_SIGNAL_MASK) have some implemented functions to call them, respectively in /crosvm/kvm/src/lib.rs#744 and /crosvm/kvm/src/lib.rs#1628. The other 4 ioctls are only declared but not implemented in /crosvm/kvm_sys/src/lib.rs

Wondering if we can add these ioctls for rust-vmm, if so, we @michael2012z will create some PRs to do that. Thanks!

andreeaflorescu commented 4 years ago

We never planned for kvm-ioctls to have all the supported ioctls. I think it make sense to add ioctls as they're needed. So I would start with the ones used by CrosVM and we can continue from there. What do you think?

MrXinWang commented 4 years ago

Hi @andreeaflorescu , thanks very much for the suggestion! Created a PR for the ioctl KVM_IRQ_LINE already, and I think my colleague will take care of the other one. Thanks.

andreeaflorescu commented 4 years ago

Closing this as we are adding ioctls on an as-needed basis.