Closed andreitraistaru closed 1 year ago
I'll fix the comments and also the test that are currently failing. Also, I'll add a test to validate the null terminator.
Thanks for the review. I'm working on addressing the comments now. I'll ping you when done.
Changing as_str() into as_cstr() in order to retrieve a null terminated string from the Cmdline struct.
Signed-off-by: Traistaru Andrei Cristian atc@amazon.com
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.