Replace include_bytes with opening files

rust-vmm / linux-loader

Linux kernel loader

Apache License 2.0

193 stars 55 forks source link

Closed andreeaflorescu closed 3 years ago

andreeaflorescu commented 3 years ago

To simplify the unit tests, we can replace include_bytes with just sending the file as a parameter.

We can remove all make* functions in src/loader/x86_64/elf/mod.rs and just call the load functions with the file.

ahmedaabouzied commented 3 years ago

@andreeaflorescu Hey is this still relevant? I can work on it if it's up for grabs.

andreeaflorescu commented 3 years ago

Ah, no, I should close this one. Sorry about that. Would you like to work on another one?

ahmedaabouzied commented 3 years ago

@andreeaflorescu yea sure. If you could point towards another available ticket, I'd gladly give it a try.

andreeaflorescu commented 3 years ago

@ahmedaabouzied I pinged you on Slack.