rust-vmm / mshv

Crates for Microsoft Hypervisor ioctls and bindings
Apache License 2.0
29 stars 12 forks source link

Nudasnev/shim get set vp state #134

Closed NunoDasNeves closed 5 months ago

NunoDasNeves commented 5 months ago

Summary of the PR

Make the get/set vp state IOCTLs simpler and easier to use. Remove any interpretation of the XSAVE state, as it is not needed for save/restore. Replace hv definitions in the interface with mshv definitions, so the kernel doesn't need to export these. Use a plain buffer for the data to simplify things.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

russell-islam commented 5 months ago

I have been discussing this changes with @NunoDasNeves and we agreed on this. This PR looks good to me. @jinankjain @liuw Could you please look into this?

liuw commented 5 months ago

I have been discussing this changes with @NunoDasNeves and we agreed on this. This PR looks good to me. @jinankjain @liuw Could you please look into this?

I don't have a strong opinion on this. If the three of you agree on a way forward I'm fine with this PR.

russell-islam commented 5 months ago

@NunoDasNeves Please add missing Signed-off-by