Rework several IOCTLs to not depend on hv_ definitions

[NunoDasNeves]

Summary of the PR

The kernel interfaces are being update to not depend on hv_ definitions directly. Update the relevant IOCTLs to work with the new interfaces.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

• [x] All commits in this PR have Signed-Off-By trailers (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
• [x] All added/changed functionality has a corresponding unit/integration test.
• [x] All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).
• [x] Any newly added unsafe code is properly documented.

[russell-islam]

I can see you remove all the Synic Features and related codes, Where are those now?

[NunoDasNeves]

I can see you remove all the Synic Features and related codes, Where are those now?

In the kernel

[russell-islam]

LGTM

[liuw]

error[E0425]: cannot find value `HV_PAGE_SIZE` in this scope
   --> mshv-ioctls/src/ioctls/vm.rs:683:49
    |
683 |         let bitmap_size = div_ceil(memory_size, HV_PAGE_SIZE * 64);
    |                                                 ^^^^^^^^^^^^ help: a constant with a similar name exists: `HV_HYP_PAGE_SIZE`
    |
   ::: /project/mshv-bindings/src/arm64/bindings.rs:194:1

This is a legit error -- missing changes for arm64.

[NunoDasNeves]

error[E0425]: cannot find value `HV_PAGE_SIZE` in this scope
   --> mshv-ioctls/src/ioctls/vm.rs:683:49
    |
683 |         let bitmap_size = div_ceil(memory_size, HV_PAGE_SIZE * 64);
    |                                                 ^^^^^^^^^^^^ help: a constant with a similar name exists: `HV_HYP_PAGE_SIZE`
    |
   ::: /project/mshv-bindings/src/arm64/bindings.rs:194:1

This is a legit error -- missing changes for arm64.

Looks like this was already broken in vcpu.rs too... Fixed!

[NunoDasNeves]

@liuw @russell-islam The cloud hypervisor build/clippy should still be failing, but it's now passing because it's ignoring the [patch] section and continuing to use v0.2.0! It shows this message:

warning: Patch `mshv-bindings v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-bindings)` was not used in the crate graph.
Patch `mshv-ioctls v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-ioctls)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.

Also, I can't repro this locally. It just fails to build (as it should) when I patch the mshv crates.

[russell-islam]

@liuw @russell-islam The cloud hypervisor build/clippy should still be failing, but it's now passing because it's ignoring the [patch] section and continuing to use v0.2.0! It shows this message:

warning: Patch `mshv-bindings v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-bindings)` was not used in the crate graph.
Patch `mshv-ioctls v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-ioctls)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.

Also, I can't repro this locally. It just fails to build (as it should) when patch the mshv crates.

We can merge this PR and use it in CLH. Will that fix the issue?

[NunoDasNeves]

We can merge this PR and use it in CLH. Will that fix the issue?

No. That would just hide the issue.

The issue is: the Cloud Hypervisor Build workflow is passing. But, that's wrong, it should be failing. It should fail because upstream CLH is not up to date with this PR (that will be fixed in https://github.com/cloud-hypervisor/cloud-hypervisor/pull/6428). So, something is wrong with the workflow.

[russell-islam]

Patching in CLH is not working then.

I am not sure about this warning.

warning: Patch mshv-bindings v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-bindings) was not used in the crate graph. Patch mshv-ioctls v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-ioctls) was not used in the crate graph. Check that the patched package version and available features are compatible with the dependency requirements. If the patch has a different version from what is locked in the Cargo.lock file, run cargo update to use the new version. This may also occur with an optional dependency that is not enabled.

[liuw]

We can merge this PR and use it in CLH. Will that fix the issue?

No. That would just hide the issue.

The issue is: the Cloud Hypervisor Build workflow is passing. But, that's wrong, it should be failing. It should fail because upstream CLH is not up to date with this PR (that will be fixed in cloud-hypervisor/cloud-hypervisor#6428). So, something is wrong with the workflow.

Can you compare the command you use for local builds and the command in the workflow.

I see that workflow builds don't use --locked.

[jinankjain]

@NunoDasNeves is it ready to merge now?

[liuw]

@NunoDasNeves is it ready to merge now?

Nuno told me it is.