search

rust-vmm / rust-vmm-ci

Apache License 2.0
18 stars 33 forks source link

Commit summary length too rigid #104

Closed liuw closed 2 years ago

liuw commented 2 years ago

The template mandates 50/72 limit. I think it is very easy to go over the 50 characters limit for the summary line.

https://github.com/rust-vmm/.github/blob/25304ffcedb6e7ecdfa77655deeace5a86b6a6b0/pull_request_template.md?plain=1#L11

andreeaflorescu commented 2 years ago

We chatted about this in the sync meeting and the proposal is to have the limit as 60 80 instead.