Closed stefano-garzarella closed 10 months ago
@roypat should we run black
on PRs?
@roypat should we run
black
on PRs?
I think it might make sense for this repository, but I'm not really a big fan of how it wraps lines. e.g. sometimes when you have a very long line that ends with a list or dictionary access, it will give you something like
very_long_thing[
0
]
which... why?
@roypat should we run
black
on PRs?I think it might make sense for this repository, but I'm not really a big fan of how it wraps lines. e.g. sometimes when you have a very long line that ends with a list or dictionary access, it will give you something like
very_long_thing[ 0 ]
which... why?
yeah, I see!
I mentioned this because this is the second time after merging a PR, I get a notification that black
fails, and as a python profane I didn't launch it locally before sending the previous PR :-(
Summary of the PR
black
suggests putting the string between single quotes so there is no need to escape double quotes.Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.