rust-vmm / rust-vmm-ci

Apache License 2.0
18 stars 33 forks source link

Fix commit format test #28

Closed lauralt closed 4 years ago

lauralt commented 4 years ago

Even though origin was pointing to the right upstream repo, the repo wasn't fetched and because of that, we ended comparing HEAD with a wrong master. The commit format test for the following dummy PR: https://github.com/rust-vmm/kvm-ioctls/pull/109 is passing now (which is the expected behavior).

Also, it looks like we had the same problem in the benchmark test. I fixed that too, but this change (and basically the entire test) can be properly tested in a PR that actually uses it (for example https://github.com/rust-vmm/linux-loader/pull/46). Nevertheless, I expect fetching is necessary here too.