Add linter test for shell scripts

rust-vmm / rust-vmm-ci

Apache License 2.0

18 stars 33 forks source link

Add linter test for shell scripts #44

Open aghecenco opened 3 years ago

aghecenco commented 3 years ago

Depends on https://github.com/rust-vmm/rust-vmm-container/issues/30

andreeaflorescu commented 3 years ago

The container with shellcheck is now published.

For this we need to:

find all bash files
run shellcheck for them

This can be a test under integration_tests, and it needs to be running in the buildkite pipeline.

nathanwhyte commented 1 year ago

Hi Alexandra and Andreea,

I'm taking a Virtualization course at UT Austin and we've been asked to contribute to open-source virtualization repositories for one of our projects. Could I take a shot at resolving this issue?

andreeaflorescu commented 1 year ago

Hmmm, we don't have a lot of shell scripts, and this is not a main focus of the project. I am not sure this is the right problem to tackle. I would be inclined to just close it instead. @lauralt wdyt?