search

rust-vmm / rust-vmm-ci

Apache License 2.0
18 stars 33 forks source link

vhost vdpa: expose device to container #65

Closed alxiord closed 3 years ago

alxiord commented 3 years ago

This PR exposes the /dev/vhost-vdpa-0 device to the test container, to unblock testing vhost-vdpa support properly (see https://github.com/rust-vmm/vhost/pull/33).

Do not merge until the CI images are upgraded so that the /dev/vhost-vdpa-0 device exists on the host.

64

andreeaflorescu commented 3 years ago

I think we might need to take a step back and think about how we want to support this in the future. It looks a bit odd to need to make the rust-vmm-ci device specific. What I have in mind is maybe thinking about the possibility for the rust-vmm-ci pipeline to be configurable, allowing the individual CIs to set additional parameters somehow.

Depending on how hard that might actually be, we can take the shortcut in this PR temporarily.

andreeaflorescu commented 3 years ago

This is no longer needed because we're adding the changes in vhost directly. We still need to figure out a nicer way to pass custom configurations to rust-vmm-ci. I'll open a separate issue for that.