search

rust-vmm / rust-vmm-container

Container with all dependencies required for running rust-vmm crates integration tests.
Apache License 2.0
65 stars 32 forks source link

build_container: Add tools required by bindgen #78

Closed vireshk closed 1 year ago

vireshk commented 1 year ago

Some packages need to build FFI bindings dynamically using 'bindgen' and 'bindgen' requires libclang-dev to be available.

This was removed accidentally by commit d1a36b4b2af5 ("reduce the size occupied during build by container").

Get it back.

andreeaflorescu commented 1 year ago

@vireshk thanks for fixing this! We are also planning on updating the the newest Rust version, do you mind adding that change in the same PR? Otherwise we will have two subsequent container versions published.

@roypat was going to open a PR this week, but I think it's okay to just capture the change in this already opened PR, in a separate commit.

vireshk commented 1 year ago

@vireshk thanks for fixing this! We are also planning on updating the the newest Rust version, do you mind adding that change in the same PR? Otherwise we will have two subsequent container versions published.

Done.

andreeaflorescu commented 1 year ago

@vireshk once this is merged, can you please open a PR in rust-vmm-ci to update the version as well?