search

rust-vmm / rust-vmm-container

Container with all dependencies required for running rust-vmm crates integration tests.
Apache License 2.0
65 stars 32 forks source link

build_container: use git cli to avoid OOM on arm64 #80

Closed stefano-garzarella closed 1 year ago

stefano-garzarella commented 1 year ago

libgit2 can consume a lot of memory when cross-compiling for arm64. As suggested here [1], let's use the git executable to prevent this issue.

[1] https://github.com/rust-lang/cargo/issues/10583#issuecomment-1129997984

Fixes: https://github.com/rust-vmm/rust-vmm-container/issues/79

stefano-garzarella commented 1 year ago

Note: I'm not sure if it will fix completely our issue, let's wait if the cargo install is killed or not during the build :-) but https://github.com/rust-lang/cargo/issues/10583 seems very similar to our problem.

stefano-garzarella commented 1 year ago

It seems it worked: https://github.com/rust-vmm/rust-vmm-container/actions/runs/4636483206/jobs/8204413932?pr=80#step:7:4110

But I think we can be sure only when we merge this.

andreeaflorescu commented 1 year ago

Thanks for taking a look at this!