search

rust-vmm / seccompiler

Provides easy-to-use Linux seccomp-bpf jailing.
https://crates.io/crates/seccompiler
Apache License 2.0
77 stars 11 forks source link

Requirement for “signed” commits in PR template is confusing #70

Closed Hawk777 closed 10 months ago

Hawk777 commented 11 months ago

The PR template says:

All commits in this PR are signed (with git commit -s)

As someone who doesn’t tend to remember which one is -s and which one is -S, I found this wording confusing: IMO the word “signed”, on its own, means cryptographically signed, i.e. -S; I think this is probably the more common understanding. IMO something like “signed off” would be sufficient to eliminate the confusion, though there might be other rewordings that would be even more clear.

alindima commented 10 months ago

The PR template is part of: https://github.com/rust-vmm/.github. Feel free to open a PR there. Personally, I don't think it's a big deal as long as it says git commit -s, but I can also understand the confusion