Open kxxt opened 5 months ago
thanks for the contribution. while it overall looks good, we don't have any riscv support in the CI. Without that, I don't think we can merge such PRs, since it would basically result in untested code being released. I noticed at least one other rust-vmm crate which has open PRs for riscv support also. Is there such planned support? CC: @andreeaflorescu (mentioning you since you may have an opinion on this)
while it overall looks good,
Thank!
while it overall looks good, we don't have any riscv support in the CI.
It looks like there's a PR adding that: https://github.com/rust-vmm/rust-vmm-ci/pull/148
Without that, I don't think we can merge such PRs, since it would basically result in untested code being released.
I think another possible way could be merging riscv64 support and labeling riscv64 as a community supported and not officially tested architecture in the documentation.
BTW here is a test log on riscv64: https://paste.rs/Oyi0p
Summary of the PR
Add riscv64 support.
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.