rust-vmm / vfio

14 stars 20 forks source link

build(deps): bump rust-vmm-ci from `5f36cc9` to `7af2e16` #17

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps rust-vmm-ci from 5f36cc9 to 7af2e16.

Commits
  • 7af2e16 add support for specifying the agent queue
  • e2e2918 generate pipeline: support for FW unknown keys
  • b0edd17 autogenerate_pipeline: use dictionary instead of self
  • edd221a don't allow undocumented unsafe blocks
  • See full diff in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
liuw commented 1 year ago

I don't see this error when running the same command locally.

Compiling mshv-bindings v0.1.1 (https://github.com/rust-vmm/mshv?branch=main#ed66a5ad)
--
  | error: cannot find macro `generate_fam_struct_impl` in this scope
  | --> /root/.cargo/git/checkouts/mshv-cc59226ef45dad4f/ed66a5a/mshv-bindings/src/fam_wrappers.rs:11:1
  | \|
  | 11 \| generate_fam_struct_impl!(msrs, msr_entry, entries, u32, nmsrs, MAX_MSR_ENTRIES);
  | \| ^^^^^^^^^^^^^^^^^^^^^^^^
  | \|
  | = note: consider importing this macro:
  | vmm_sys_util::generate_fam_struct_impl
  |  
  | error: cannot find macro `generate_fam_struct_impl` in this scope
  | --> /root/.cargo/git/checkouts/mshv-cc59226ef45dad4f/ed66a5a/mshv-bindings/src/fam_wrappers.rs:19:1
  | \|
  | 19 \| generate_fam_struct_impl!(
  | \| ^^^^^^^^^^^^^^^^^^^^^^^^
  | \|
  | = note: consider importing this macro:
  | vmm_sys_util::generate_fam_struct_impl
  |  
  | error: cannot find macro `generate_fam_struct_impl` in this scope
  | --> /root/.cargo/git/checkouts/mshv-cc59226ef45dad4f/ed66a5a/mshv-bindings/src/fam_wrappers.rs:28:1
  | \|
  | 28 \| generate_fam_struct_impl!(msr_list, u32, indices, u32, nmsrs, MAX_MSR_ENTRIES);
  | \| ^^^^^^^^^^^^^^^^^^^^^^^^
  | \|
  | = note: consider importing this macro:
  | vmm_sys_util::generate_fam_struct_impl
  |  
  | error: could not compile `mshv-bindings` due to 3 previous errors
  | 🚨 Error: The command exited with status 101
andreeaflorescu commented 1 year ago

@liuw can you delete the Cargo.lock and re-run it? It might be that you locally use another version of one of the dependencies and that's why you don't see the error.

liuw commented 1 year ago

@liuw can you delete the Cargo.lock and re-run it? It might be that you locally use another version of one of the dependencies and that's why you don't see the error.

I did. It worked fine. And I tested main and this PR.

I don't think mshv changed anything regarding generate_fam_struct_impl recently.

liuw commented 1 year ago

BTW the mshv crate itself is using the exact rust-vmm-ci commit this PR proposes.

liuw commented 1 year ago

@dependabot recreate

liuw commented 1 year ago

Oh I am blind. Those failures are on aarch64. I don't think that's supported.

liuw commented 1 year ago

@andreeaflorescu the other failures are due to missing safety comments for generated bindings. How do you want to proceed?

liuw commented 1 year ago

@dependabot recreate

liuw commented 1 year ago

I sent out #18 to address those clippy warnings.