ioctls: reenable support of mshv

[jiangliu]

The vfio-ioctls v0.1.0 has been published, so reenable support of mshv.

Signed-off-by: Liu Jiang gerry@linux.alibaba.com

[liuw]

Changes look good. I think you missed bumping the version number.

In any case, this will need to wait until we publish mshv crates to crates.io.

[jiangliu]

Changes look good. I think you missed bumping the version number.

In any case, this will need to wait until we publish mshv crates to crates.io.

The version number will be bumped when publishing next version:)

[jiangliu]

Can we first discuss about publishing mshv? I have some concerns regarding this. It seems like the publishing of the mshv-* crates is rushed because of vfio-ioctls (for example, the coverage of the crate is now ~25% which is very low compared to all the other crates published in crates.io).

The initial plan as I understood from other comments was to publish mshv in January. Can we wait with the update until then? More comments on this topic here: rust-vmm/mshv#25 (comment)

We have already published vfio-ioctls v0.1 without support of mshv, and there's no plan for v0.2 yet. So no rush for mshv anymore. We could publish v0.2 for mshv according to mshv's plan.

[jiangliu]

This is just to reenable vfio-ioctls for mshv, so that Cloud hypervisor may consume the main branch.

[sboeuf]

@liuw @rbradford that's a bit problematic that we don't have the mshv support anymore because Cloud Hypervisor can't move from the now deprecated rust-vmm/vfio-ioctls crate to rust-vmm/vfio. I can only see two options here, either we disable the need for mshv from Cloud Hypervisor, or we push for the mshv support to be merged in rust-vmm/vfio (effectively pushing for this PR to be merged).

[jiangliu]

I feel the solution is to merge this PR first to unblock Cloud Hypervisor. Then move on to publish the mshv crate.

[liuw]

Thanks @jiangliu . @sboeuf let me know if anything else is needed.

[sboeuf]

No everything's good!