ioctls: Convert mshv_ioctls::Result's errno using into()

NunoDasNeves commented 5 months ago

This allows the new MshvError Result type to be returned from the mshv-ioctls crate and converted appropriately.

This is backwards-compatible with the old errno:Error Result type.

Summary of the PR

See https://github.com/rust-vmm/mshv/pull/138 for further details.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

[x] All commits in this PR have Signed-Off-By trailers (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
[x] All added/changed functionality has a corresponding unit/integration test.
[x] All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.

NunoDasNeves commented 5 months ago

NOTE: The clippy error: useless conversion to the same type: `kvm_ioctls::Error` is present because the upstream mshv crate has not yet been updated. This error disappears with the changes in https://github.com/rust-vmm/mshv/pull/138

NunoDasNeves commented 4 months ago

https://github.com/rust-vmm/mshv/pull/138 has been merged

NunoDasNeves commented 4 months ago

@sboeuf @liuw is it possible to re-run the buildkite check? I think it will pass now

liuw commented 4 months ago

@NunoDasNeves not sure how it can be done. Perhaps try pushing to your branch again?

sboeuf commented 4 months ago

@NunoDasNeves I don't have a buildkite account to re-trigger the build. I agree with @liuw that you can simply force push to the same branch.

jinankjain commented 4 months ago

I think this PR is no longer required. This change was already included in 4e937a514d9025f953eeb837fb8dafe035d9a8fd

rust-vmm / vfio

ioctls: Convert mshv_ioctls::Result's errno using into() #44

Summary of the PR

Requirements