rust-vmm / vhost-device

'vhost-user' device backends workspace
Apache License 2.0
68 stars 48 forks source link

scmi: unused methods #694

Closed stefano-garzarella closed 4 months ago

stefano-garzarella commented 4 months ago

@mz-pdm can we remove those methods since they are not used, or have we forgotten to use them somewhere?

$ rustc --version
rustc 1.78.0 (9b00956e5 2024-04-29)

$ cargo build -p vhost-device-scmi
   Compiling vhost-device-scmi v0.2.0 (/home/stefano/repos/vhost-device/target/package/vhost-device-scmi-0.2.0)
warning: methods `invalid_property` and `process_property` are never used
   --> src/devices/common.rs:301:8
    |
276 | pub trait SensorT: Send {
    |           ------- methods in this trait
...
301 |     fn invalid_property(&self, name: &str) -> Result<(), DeviceError> {
    |        ^^^^^^^^^^^^^^^^
...
308 |     fn process_property(&mut self, name: &str, _value: &str) -> Result<(), De...
    |        ^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: `vhost-device-scmi` (bin "vhost-device-scmi") generated 1 warning
mz-pdm commented 4 months ago

We can remove them, PR posted.