search

rust-vmm / vhost-user-backend

Deprecated repository, code now lives in: https://github.com/rust-vmm/vhost/
Apache License 2.0
18 stars 16 forks source link

Pull and rebase CH vhost-user-backend commits #1

Closed slp closed 3 years ago

slp commented 3 years ago

This is still needs some changes to get it up to rust-vmm's standards, but I think it's a good starting point.

slp commented 3 years ago

We'd also need some volunteers to act as code owners. I volunteer myself. @sboeuf @rbradford @alexandruag @jiangliu would you be interested?

jiangliu commented 3 years ago

We'd also need some volunteers to act as code owners. I volunteer myself. @sboeuf @rbradford @alexandruag @jiangliu would you be interested?

Sure, I'm glad to help here:)

slp commented 3 years ago

Can we get the vm-virtio and vhost changes upstream first so we can depend on the rust-vmm versions instead of these forks?

@rbradford Either I did something wrong while creating the PR, or you're reviewing an interim commit, because with all changes applied, it should only depend on rust-vmm's crates. In fact, GitHub marks as Outdated your comments on Cargo.toml. :-?

rbradford commented 3 years ago

Can we get the vm-virtio and vhost changes upstream first so we can depend on the rust-vmm versions instead of these forks?

@rbradford Either I did something wrong while creating the PR, or you're reviewing an interim commit, because with all changes applied, it should only depend on rust-vmm's crates. In fact, GitHub marks as Outdated your comments on Cargo.toml. :-?

Yeh, no idea how that happened...but I can see it's all great now! Pleased to see the progress.

alexandruag commented 3 years ago

We'd also need some volunteers to act as code owners. I volunteer myself. @sboeuf @rbradford @alexandruag @jiangliu would you be interested?

Thanks for considering, and I'll be happy to help whenever I'm able to, but I don't think I have sufficient context in this area yet to officially show up as a code owner :-s

rbradford commented 3 years ago

@slp Can you add @sboeuf (he's away currently but he did write a lot of the code originally)

slp commented 3 years ago

@slp Can you add @sboeuf (he's away currently but he did write a lot of the code originally)

Sure! Done.

rbradford commented 3 years ago

@slp Can you add @sboeuf (he's away currently but he did write a lot of the code originally)

Sure! Done.

Looks like it's still missing to me...but maybe this is my GitHub :ghost: again...

slp commented 3 years ago

@slp Can you add @sboeuf (he's away currently but he did write a lot of the code originally)

Sure! Done.

Looks like it's still missing to me...but maybe this is my GitHub ghost again...

Nope, this time it's really missing (wrong force push). I'm creating a new PR.