search

rust-vmm / vhost-user-backend

Deprecated repository, code now lives in: https://github.com/rust-vmm/vhost/
Apache License 2.0
18 stars 16 forks source link

Various vring fixes #18

Closed slp closed 3 years ago

slp commented 3 years ago

This PR includes two important fixes, and two minor style and functional improvements.

The important ones fix a behavior issue that may lead to the vhost-user device to miss signalling a completion event to the Guest, and the fact the we weren't resetting the underlying Queue at any time.

slp commented 3 years ago

@sboeuf These changes should only have an impact on vring initialization, so I tested boot and reboot (in addition to device functionality) with virtiofsd-rs and the new vhost-device/scsi as devices, and QEMU as VMM (I should probably add another VMM to my dev environment 🤔)

slp commented 3 years ago

@jiangliu @sboeuf PTAL

jiangliu commented 3 years ago

Could you please help to rebase the MR?

slp commented 3 years ago

Could you please help to rebase the MR?

Done. :-)