search

rust-vmm / vhost-user-backend

Deprecated repository, code now lives in: https://github.com/rust-vmm/vhost/
Apache License 2.0
18 stars 16 forks source link

Fix a bug in VringT definition #35

Closed jiangliu closed 3 years ago

jiangliu commented 3 years ago

Backend::handle_event() takes an argument of vrings: &[V] with V: VringT, so methods of VringT should not take &mut self.

vireshk commented 3 years ago

Made my error go away. Thanks @jiangliu

jiangliu commented 3 years ago

LGTM. Also, thanks for the much needed update to README.md.

I'm too weak at documentation, help is welcomed for enhancing document.

stefano-garzarella commented 3 years ago

The final result looks great! Maybe we can split commit https://github.com/rust-vmm/vhost-user-backend/pull/35/commits/08e83f72234d946ee78c35963b949229d0d440a3 in two commits, moving the function documentation in a separate commit (thanks for that), but I don't have a strong opinion on that.

jiangliu commented 3 years ago

The final result looks great! Maybe we can split commit 08e83f7 in two commits, moving the function documentation in a separate commit (thanks for that), but I don't have a strong opinion on that.

The documentation is associated with the interface change, so let keep them together?

stefano-garzarella commented 3 years ago

The documentation is associated with the interface change, so let keep them together?

Yep, good point, best to keep them together.