search

rust-vmm / vhost-user-backend

Deprecated repository, code now lives in: https://github.com/rust-vmm/vhost/
Apache License 2.0
18 stars 16 forks source link

Upgrade the virtio-queue dependency to the latest vm-virtio revision #47

Closed mathieupoirier closed 2 years ago

mathieupoirier commented 2 years ago

Using the latest virtio-queue revision is the first step in allowing crates that include vhost-user-backend to test different Mutex/RwLockVring manipulations. The MockSplitQueue implements the virtio backend side of the equation and is able to insert DescriptorChains in the VringMutex/RwLocks. Those are then processed by the handle_event() method of types that implement the VhostUserBackend and VhostUserBackendMut traits.

stefano-garzarella commented 2 years ago

In #46, to update the vm-memory crate, we also updated virtio-queue, the changes required by this issue should also be included, right?

stefano-garzarella commented 2 years ago

In #46, to update the vm-memory crate, we also updated virtio-queue, the changes required by this issue should also be included, right?

I mean this commit included in the PR #46: https://github.com/rust-vmm/vhost-user-backend/pull/46/commits/8198885cd02b87f8dd87afb353a4f6e6c2f9985d

mathieupoirier commented 2 years ago

I'm not sure to understand the above comment but from looking at PR8198885, is seems like the same thing needs to be done here with vhost-user-backend.

stefano-garzarella commented 2 years ago

That commit is for this crate, and now is merged in the main branch, so you should have the latest API of virtio-queue available here.

If you agree, we can close this issue.

mathieupoirier commented 2 years ago

Apologies for the late follow-up - I did not see the last line of the latest comment. Thanks for doing that - I will start looking into integrating with the MockSplitQueue in the comings days.