search

rust-vmm / vhost-user-backend

Deprecated repository, code now lives in: https://github.com/rust-vmm/vhost/
Apache License 2.0
18 stars 16 forks source link

build: Relax vm-memory dependency #69

Closed rbradford closed 2 years ago

rbradford commented 2 years ago

This allows the use of newer versions of the vm-memory crate when combined with other dependencies.

Signed-off-by: Rob Bradford robert.bradford@intel.com

rbradford commented 2 years ago

This will not build until virtio-queue crate is released with the fix in https://github.com/rust-vmm/vm-virtio/pull/159 is merged.

andreeaflorescu commented 2 years ago

The tests are failing, I think updates are needed to the vhost-user-backend interfaces. It looks like 0.7.0 and 0.8.0 are not backward compatible.

andreeaflorescu commented 2 years ago

The tests are failing, I think updates are needed to the vhost-user-backend interfaces. It looks like 0.7.0 and 0.8.0 are not backward compatible.

Nvm, just saw @rbradford comment above.

sboeuf commented 2 years ago

@rbradford can you push this again so that buildkite will run again and so that we can merge it?

sboeuf commented 2 years ago

@rbradford oh I just realized this is more complicated than that. Basically you needed to bump to virtio-queue 0.3.0 as well, but since virtio-queue 0.3.0 introduced some breaking changes, this change will need more patches. Let me have a look at it.

sboeuf commented 2 years ago

@rbradford nevermind, there's no changes in virtio-queue 0.3.0 that's breaking vhost-user-backend. All you need to do is to bump virtio-queue from 0.2.0 to 0.3.0 in Cargo.toml and we'll be able to merge it.

sboeuf commented 2 years ago

@slp @stefano-garzarella could you please add your review?