search

rust-vmm / vhost-user-backend

Deprecated repository, code now lives in: https://github.com/rust-vmm/vhost/
Apache License 2.0
18 stars 16 forks source link

Build on main fails #82

Closed andreeaflorescu closed 1 year ago

andreeaflorescu commented 2 years ago

I think this might be due to an update in one of the dependencies: https://buildkite.com/rust-vmm/vhost-user-backend-ci/builds/184. We've updated the way we specify dependencies in vm-memory, virtio-queue, and vmm-sys-util. We should also sue caret dependencies in this crate as well to avoid failures.

Failed build: https://buildkite.com/rust-vmm/vhost-user-backend-ci/builds/184

slp commented 2 years ago

As virtio-queue 0.5.0 was released with vm-memory = 0.8, while for vhost 0.4.0 and vhost-user-backend 0.6.0 it's vm-memory >= 0.6 and vm-memory >= 0.8 respectively, two versions of the library are being pulled, vm-memory 0.8 (for vhost) and vm-memory 0.9 (for the others).

To fix this, we need to release a new version of virtio-queue and vhost (both upstreams now depend on vm-memory = 0.9), and then we can update vhost-user-backend.

andreeaflorescu commented 2 years ago

@slp thanks for the explanation, can you create a new release of virtio-queue?

slp commented 2 years ago

@andreeaflorescu I looked into doing that, but I saw your comment here and I wasn't sure it we can do that already.

andreeaflorescu commented 2 years ago

Hmm yes, we didn't update the rust-vmm-ci version. I can submit a PR with that so we can capture the version update as well. Dependabot didn't yet picked up that update because the rust-vmm-ci was merged pretty late. I can do a manual update.

andreeaflorescu commented 2 years ago

@slp we merged the Rust version update in vm-virtio. I think we can now do the release for virtio-queue. Thanks for your patience!

slp commented 2 years ago

@andreeaflorescu Ack, I'll do that tomorrow, and I'll also update vhost-user-backend once that one hits crates.io.

stefano-garzarella commented 1 year ago

@slp @andreeaflorescu IIUC commit https://github.com/rust-vmm/vhost-user-backend/commit/917e85a3d5d73edd4d2004d10724c7e6a63dce43 should fix this issue and it's released with v0.7.0, so can we close this issue?

andreeaflorescu commented 1 year ago

Sure. Feel free to close them yourself, I forgot about this one. One thing we're doing for other repos is to write Fixes: https://github.com/rust-vmm/vhost-user-backend/issues/82 in the commit message so that the issue is automatically closed when the PR is merged.