rust-vmm / vhost

Apache License 2.0
130 stars 69 forks source link

vhost-user-backend: remove return value from handle_event #192

Closed stefano-garzarella closed 1 year ago

stefano-garzarella commented 1 year ago

Summary of the PR

The return value of VhostUserBackend::handle_event() is undocumented and difficult to interpret. The current implementation used it to interrupt the event loop as it does when we receive an exit event.

All current implementations checked (rust-vmm/vhost-device, virtiofsd) return an error or always false, effectively not using this feature.

Since we already have a mechanism for breaking the event loop, we can avoid this ambiguous and redundant feature.

Closes #144

Requirements

Before submitting your PR, please make sure you addressed the following requirements: