The return value of VhostUserBackend::handle_event() is undocumented and difficult to interpret.
The current implementation used it to interrupt the event loop as it does when we receive an exit event.
All current implementations checked (rust-vmm/vhost-device, virtiofsd) return an error or always false, effectively not using this feature.
Since we already have a mechanism for breaking the event loop, we can avoid this ambiguous and redundant feature.
Closes #144
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
[x] All commits in this PR are signed (with git commit -s), and the commit
message has max 60 characters for the summary and max 75 characters for each
description line.
[x] All added/changed functionality has a corresponding unit/integration
test.
[x] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.
Summary of the PR
The return value of VhostUserBackend::handle_event() is undocumented and difficult to interpret. The current implementation used it to interrupt the event loop as it does when we receive an exit event.
All current implementations checked (rust-vmm/vhost-device, virtiofsd) return an error or always false, effectively not using this feature.
Since we already have a mechanism for breaking the event loop, we can avoid this ambiguous and redundant feature.
Closes #144
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.