rust-vmm / vhost

Apache License 2.0
126 stars 64 forks source link

build(deps): update vm-memory requirement from 0.12.0 to 0.13.1 #197

Closed dependabot[bot] closed 8 months ago

dependabot[bot] commented 9 months ago

Updates the requirements on vm-memory to permit the latest version.

Changelog

Sourced from vm-memory's changelog.

[v0.13.1]

Added

  • [#256] Implement WriteVolatile for std::io::Stdout.
  • [#256] Implement WriteVolatile for std::vec::Vec.
  • [#256] Implement WriteVolatile for Cursor<&mut [u8]>.
  • [#256] Implement ReadVolatile for Cursor<T: AsRef[u8]>.

[v0.13.0]

Added

  • [#247](rust-vmm/vm-memory#247) Add ReadVolatile and WriteVolatile traits which are equivalents of Read/Write with volatile access semantics.

Changed

  • [#247](rust-vmm/vm-memory#247) Deprecate Bytes::{read_from, read_exact_from, write_to, write_all_to}. Instead use ReadVolatile/WriteVolatile, which do not incur the performance penalty of copying to hypervisor memory due to Read/Write being incompatible with volatile semantics (see also #217).

[v0.12.2]

Fixed

  • [#251](rust-vmm/vm-memory#251): Inserted checks that verify that the value returned by VolatileMemory::get_slice is of the correct length.

Deprecated

  • [#244](rust-vmm/vm-memory#241) Deprecate volatile memory's as_ptr() interfaces. The new interfaces to be used instead are: ptr_guard() and ptr_guard_mut().

[v0.12.1]

Fixed

[v0.12.0]

Added

... (truncated)

Commits


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
stefano-garzarella commented 9 months ago

Still need new vm-virtio release using the new vm-memory version: https://github.com/rust-vmm/vm-virtio/pull/260

Ablu commented 8 months ago

This needs a recreate, then we should be unblocked.

stefano-garzarella commented 8 months ago

@dependabot recreate

stefano-garzarella commented 8 months ago

@Ablu yeah! Thank you very much for the effort!

Ablu commented 8 months ago

Hm... Why does this build? I forgot that this repo does not have the grouped updates yet. So I expect a bump of vm-memory and vm-virtio together to build, but why does a vm-memory only bump work?

stefano-garzarella commented 8 months ago

@Ablu I think because we don't have Cargo.lock committed. Since virtio-queue is a minor update, the CI is building v0.9.1 instead of v0.9.0

Ablu commented 8 months ago

Ah. Makes sense!

stefano-garzarella commented 8 months ago

@jiangliu @sboeuf @slp can you take a look?

Ablu commented 8 months ago

There is some discussion on Slack on whether or not to yank the bad virtio-queue release, so this probably needs to wait for that being concluded before merging.

Ablu commented 8 months ago

Blocked on https://github.com/rust-vmm/vm-virtio/pull/272, needs a recreate after the new version is published.

Ablu commented 8 months ago

Should be possible to @ependabot recreate now.

stefano-garzarella commented 8 months ago

@dependabot recreate

stefano-garzarella commented 8 months ago

@Ablu IIUC we should also update virtio-queue = "0.10.0"

stefano-garzarella commented 8 months ago

Update virtio-queue from 0.9.0 to 0.10.0 since its API depends on vm-memory

Ablu commented 8 months ago

@Ablu IIUC we should also update virtio-queue = "0.10.0"

I keep forgetting that we have no grouped updates here...

Ablu commented 8 months ago

@sboeuf: Mind to re-review? :upside_down_face:

stefano-garzarella commented 8 months ago

@Ablu IIUC we should also update virtio-queue = "0.10.0"

I keep forgetting that we have no grouped updates here...

Right, we should add it!