Closed Ablu closed 7 months ago
Quoting from the process:
Irrespective of who created the PR, all existing code owners (as defined in theCODEOWNERS file) must approve the PR before it is merged. In case there are no code owners in the repository, ask 2 gatekeepers to approve the PR for you.
@eryugey @jiangliu @sboeuf @slp gentle ping.
I think Erik can help a lot in this period that you are busy, we have several PRs to merge, and we are a bit stuck. Thanks ;-)
@jiangliu we were waiting for a full agreement.
@slp @eryugey please let us know if this is fine with you.
@jiangliu we were waiting for a full agreement.
@slp @eryugey please let us know if this is fine with you.
Sorry, I'm late, but I'm fine with it. Thanks!
@stefano-garzarella asked me whether I would be willing to help with reviews here.
While my availability will probably be a lot worse starting with next year, I should still be able to do some reviews or ocassional releases.
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.na
All added/changed functionality has a corresponding unit/integration test.na
All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).na
Any newly addedunsafe
code is properly documented.