Closed roypat closed 6 months ago
I suggest using the "vhost" prefix in the commit title since we have multiple crates in this workspace.
Looking at the history, we have other commits that touch vhost
crate code, and they were not released:
e252283 vhost_user: Fix structs memory layout
826a194 vhost_user: Remove commented code
deaaecb vhost_user: Remove unnecessary method
4fb2beb vhost_user: Remove unsafe transmute
eb452c8 vhost_user: Remove non-standard request values
We didn't use the vhost
prefix there and we did not put them in the changelog :-(
So we may add more PRs in the changelog, at least:
I suggest using the "vhost" prefix in the commit title since we have multiple crates in this workspace.
Looking at the history, we have other commits that touch
vhost
crate code, and they were not released: e252283 vhost_user: Fix structs memory layout 826a194 vhost_user: Remove commented code deaaecb vhost_user: Remove unnecessary method 4fb2beb vhost_user: Remove unsafe transmute eb452c8 vhost_user: Remove non-standard request valuesWe didn't use the
vhost
prefix there and we did not put them in the changelog :-(So we may add more PRs in the changelog, at least: #208 #205 #202
Sure, can do. Are you sure about #205 though? It looks like that one only removed some comments, which to me doesn't really seem like something to call out in a changelog.
Sure, can do.
Thanks!
Are you sure about #205 though? It looks like that one only removed some comments, which to me doesn't really seem like something to call out in a changelog.
I usually put all PRs, but actually maybe this one can be skipped since it doesn't touch the code. It's up to you ;-) I don't have a strong opinion.
Sure, can do.
Thanks!
Are you sure about #205 though? It looks like that one only removed some comments, which to me doesn't really seem like something to call out in a changelog.
I usually put all PRs, but actually maybe this one can be skipped since it doesn't touch the code. It's up to you ;-) I don't have a strong opinion.
Alright, I'll happily defer to what this project usually does :) Added the changelog entries for all the PRs to vhost that got merged since 0.9.0, please have another look in case I misunderstood some of the changes!
@roypat we should also release vhost-user-backend
, but I don't want to ask you too much ;-)
I can do it if you don't have time.
@roypat we should also release
vhost-user-backend
, but I don't want to ask you too much ;-)I can do it if you don't have time.
I think vhost-user-backend first needs some of the vm-virtio crates to be released :( I can look into that this afternoon, but if you have some time before then, I appreciate any help xP
I think vhost-user-backend first needs some of the vm-virtio crates to be released :(
Right, plus both vhost
and vhost-user-backend
depends on vm-memory
which depends on vmm-sys-util
.
If vm-memory
is also going to be updated soon, should we wait to release vhost
?
I can look into that this afternoon, but if you have some time before then, I appreciate any help xP
Not until tomorrow, sorry! Let's stay updated on slack so we don't duplicate work ;-)
I think vhost-user-backend first needs some of the vm-virtio crates to be released :(
Right, plus both
vhost
andvhost-user-backend
depends onvm-memory
which depends onvmm-sys-util
. Ifvm-memory
is also going to be updated soon, should we wait to releasevhost
?
ah crap, I didnt even realize vm-memory depends on vmm-sys-util (didnt show up in cargo tree
for me because its behind the xen feature flag >.>). Yeah, I guess that has to happen first then.
I can look into that this afternoon, but if you have some time before then, I appreciate any help xP
Not until tomorrow, sorry! Let's stay updated on slack so we don't duplicate work ;-)
Sounds good! I should be able to do vm-memory today at least, and then lets sync :)
Alright, this one will need another revision once vm-virtio has an update out, but then we should hopefully be done!
Alright, this one will need another revision once vm-virtio has an update out, but then we should hopefully be done!
Okay, but vm-virtio crates are only used in vhost-user-backend (which is now failing after updating vm-memory). So maybe is better to prepare also the new release of vhost-user-backend in this PR. WDYT?
Alright, this one will need another revision once vm-virtio has an update out, but then we should hopefully be done!
Okay, but vm-virtio crates are only used in vhost-user-backend (which is now failing after updating vm-memory). So maybe is better to prepare also the new release of vhost-user-backend in this PR. WDYT?
Ah yes, can do!
This release only includes a dependency update, which is visible in the public API through
VhostBackend::set_vring_kick
andVhostBackend::set_vring_call
.Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.