Closed stefano-garzarella closed 8 months ago
v2:
For now I have left the rust-vmm-ci
pipeline active, but as soon as we merge this one I will deactivate it.
Should we run clippy
and cargo test
also with default features? Or cargo build
is enough?
(for now I just tried to replicate rust-vmm-ci
, so maybe we can think about that later)
Should we run
clippy
andcargo test
also with default features? Orcargo build
is enough? (for now I just tried to replicaterust-vmm-ci
, so maybe we can think about that later)
I do not mind. So let's keep it simple? Probably time is better spent on trying to solve https://github.com/rust-vmm/rust-vmm-ci/issues/152 :).
Summary of the PR
This is based on
rust-vmm-ci/.buildkite/test_description.json
. We can't run rust-vmm-ci tests because they enable all the features with--all-features
and our crates have features that may not be compatible with others (e.g.xen
). Waiting to solve this problem in rust-vmm-ci (see https://github.com/rust-vmm/rust-vmm-ci/issues/152), we use a custom pipeline based on that but that does not use--all-features
.Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.