rust-vmm / vhost

Apache License 2.0
130 stars 69 forks source link

tests: add rust-vmm-ci-tests.json pipeline #229

Closed stefano-garzarella closed 8 months ago

stefano-garzarella commented 8 months ago

Summary of the PR

This is based on rust-vmm-ci/.buildkite/test_description.json. We can't run rust-vmm-ci tests because they enable all the features with --all-features and our crates have features that may not be compatible with others (e.g. xen). Waiting to solve this problem in rust-vmm-ci (see https://github.com/rust-vmm/rust-vmm-ci/issues/152), we use a custom pipeline based on that but that does not use --all-features.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

stefano-garzarella commented 8 months ago

v2:

stefano-garzarella commented 8 months ago

For now I have left the rust-vmm-ci pipeline active, but as soon as we merge this one I will deactivate it.

stefano-garzarella commented 8 months ago

Should we run clippy and cargo test also with default features? Or cargo build is enough? (for now I just tried to replicate rust-vmm-ci, so maybe we can think about that later)

Ablu commented 8 months ago

Should we run clippy and cargo test also with default features? Or cargo build is enough? (for now I just tried to replicate rust-vmm-ci, so maybe we can think about that later)

I do not mind. So let's keep it simple? Probably time is better spent on trying to solve https://github.com/rust-vmm/rust-vmm-ci/issues/152 :).