search

rust-vmm / vm-fdt

Apache License 2.0
13 stars 14 forks source link

Improve the vm-fdt abstractions for v0.2.0 #22

Open andreeaflorescu opened 3 years ago

andreeaflorescu commented 3 years ago

We can improve the vm-fdt abstractions after we publish an initial version of the crate so that we do not block the first release.

The current interface was built on purpose to be similar to the libfdt one, but we can optimize it (slightly) for Rust.

Things that can be improved are better abstractions for nodes. For example, we can have the property_* functions on the FdtWriterNode instead of FdtWriter so that we can disallow properties to be added in non valid locations (see #19).

danielverkamp commented 3 years ago

This sounds like a good idea to me - anything we can do to enforce valid DT output using API design is welcome.

I think it might be possible to use Rust's ownership/lifetime semantics to help with this as well; it would be good to ensure that a FdtWriterNode can only be passed to end_node on the FdtWriter that created it, for example. I tried to add a reference back to FdtWriter in FdtWriterNode when initially writing the Rust API, but I got stuck trying to get right lifetime annotations to make the borrow checker happy; maybe somebody with more Rust experience or more perseverance can help to figure this out.