rust-vmm / vm-fdt

Apache License 2.0
14 stars 16 forks source link

Support `no_std` targets #68

Closed mkroening closed 1 year ago

mkroening commented 1 year ago

Summary of the PR

This adds no_std support by

Hashbrown also provides the HashSet implementation in std. std's HashSet is not in liballoc yet, though. By default, Hashbrown uses AHash as the default hasher. AHash is much faster than std's SipHash, but is not as HashDoS resistant. That seemed not relevant to me, though.

Closes https://github.com/rust-vmm/vm-fdt/issues/61

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

mkroening commented 1 year ago

I don't know how to modify CI to test this. Locally, I ran the following for testing:

cargo test
cargo test --no-default-features
cargo check --target x86_64-unknown-none --no-default-features
andreeaflorescu commented 1 year ago

I don't know how to modify CI to test this. Locally, I ran the following for testing:

cargo test
cargo test --no-default-features
cargo check --target x86_64-unknown-none --no-default-features

To test this as part of the CI you'll need to add a custom pipeline. Here is an example of a custom pipeline in another repository: https://github.com/rust-vmm/vm-virtio/tree/main/.buildkite. Once we get close with merging this PR, I can make the pipeline run on all PRs by configuring it in Buildkite.

mkroening commented 1 year ago

To test this as part of the CI you'll need to add a custom pipeline. Here is an example of a custom pipeline in another repository: https://github.com/rust-vmm/vm-virtio/tree/main/.buildkite. Once we get close with merging this PR, I can make the pipeline run on all PRs by configuring it in Buildkite.

I added a CI config. 👍

andreeaflorescu commented 1 year ago

I added the custom pipeline in Buildkite and retriggered the build. Any other PRs open against vm-fdt will fail the tests until this one is merged. If this becomes a problem I can also de-activate the custom build.

mkroening commented 1 year ago

Thanks :)

Sorry for dismissing the reviews. I force-pushed the fix for the CI.

mkroening commented 1 year ago

Thanks a lot! When can we expect a release? :)

andreeaflorescu commented 1 year ago

Thanks a lot! When can we expect a release? :)

I can just create one now.