Closed mkroening closed 1 year ago
I don't know how to modify CI to test this. Locally, I ran the following for testing:
cargo test
cargo test --no-default-features
cargo check --target x86_64-unknown-none --no-default-features
I don't know how to modify CI to test this. Locally, I ran the following for testing:
cargo test cargo test --no-default-features cargo check --target x86_64-unknown-none --no-default-features
To test this as part of the CI you'll need to add a custom pipeline. Here is an example of a custom pipeline in another repository: https://github.com/rust-vmm/vm-virtio/tree/main/.buildkite. Once we get close with merging this PR, I can make the pipeline run on all PRs by configuring it in Buildkite.
To test this as part of the CI you'll need to add a custom pipeline. Here is an example of a custom pipeline in another repository: https://github.com/rust-vmm/vm-virtio/tree/main/.buildkite. Once we get close with merging this PR, I can make the pipeline run on all PRs by configuring it in Buildkite.
I added a CI config. 👍
I added the custom pipeline in Buildkite and retriggered the build. Any other PRs open against vm-fdt will fail the tests until this one is merged. If this becomes a problem I can also de-activate the custom build.
Thanks :)
Sorry for dismissing the reviews. I force-pushed the fix for the CI.
Thanks a lot! When can we expect a release? :)
Thanks a lot! When can we expect a release? :)
I can just create one now.
Summary of the PR
This adds
no_std
support bystd
feature for disablingimpl Error
onno_std
.no_std
hash setsHashbrown also provides the
HashSet
implementation instd
.std
'sHashSet
is not in liballoc yet, though. By default, Hashbrown uses AHash as the default hasher. AHash is much faster thanstd
's SipHash, but is not as HashDoS resistant. That seemed not relevant to me, though.Closes https://github.com/rust-vmm/vm-fdt/issues/61
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.