search

rust-vmm / vm-memory

Virtual machine's guest memory crate
Apache License 2.0
309 stars 103 forks source link

do not return out bound error for read and write when volatile slice is empty #186

Closed aftersnow closed 2 years ago

aftersnow commented 2 years ago

To keep Consistent with the standard library, return ok(0) instead of out bound error when volatile slice is empty.

andreeaflorescu commented 2 years ago

The change LGTM, but can you please check the CI failures? You should sign your commit and shorten the first line of the commit message to fit in 50 chars, and add a test to check the newly introduced behavior.

bonzini commented 2 years ago

Looks good to me too, but having a testcase would be nicer.

lauralt commented 2 years ago

@aftersnow can you update the PR or should we push to your branch? Thanks.

lauralt commented 2 years ago

Superseded by #190