search

rust-vmm / vm-memory

Virtual machine's guest memory crate
Apache License 2.0
299 stars 97 forks source link

volatile_memory: Deprecate .as_ptr() interfaces #244

Closed vireshk closed 1 year ago

vireshk commented 1 year ago

The .as_ptr() interface can't be used with the xen feature. Mark them deprecated with a note to use the new interfaces.

andreeaflorescu commented 11 months ago

This breaks the vm-virtio/vsock build. How can the new interface be used in that case? See: https://github.com/rust-vmm/vm-virtio/pull/254 CC: @vireshk @roypat

vireshk commented 10 months ago

This breaks the vm-virtio/vsock build. How can the new interface be used in that case? See: rust-vmm/vm-virtio#254 CC: @vireshk @roypat

Hi @andreeaflorescu

Sorry for the late reply. I was out of office for sometime. Is this issue resolved or you still need someone to look into this ?

vireshk commented 10 months ago

Sorry for the late reply. I was out of office for sometime. Is this issue resolved or you still need someone to look into this ?

Okay, fixed it.

https://github.com/rust-vmm/vm-virtio/pull/257