rust-vmm / vm-superio

Emulation for legacy devices
Apache License 2.0
30 stars 25 forks source link

Implement `std::error::Error` for error types #110

Closed JonathanWoollett-Light closed 3 months ago

JonathanWoollett-Light commented 5 months ago

There are error types present that do not implement std::error::Error e.g. https://github.com/rust-vmm/vm-superio/blob/main/vm-superio/src/serial.rs#L281:L290.

This makes error propagation more difficult in dependent crates e.g. https://github.com/firecracker-microvm/firecracker/pull/4585#pullrequestreview-2031394720.

These types should implement std::error::Error.