search

rust-vmm / vm-superio

Emulation for legacy devices
Apache License 2.0
30 stars 25 forks source link

Bump rust-vmm-ci from `aee82cf` to `d216a46` #78

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 2 years ago

Bumps rust-vmm-ci from aee82cf to d216a46.

Commits
  • d216a46 Update to rustvmm/dev:v15 with Rust 1.58.1
  • d023262 Use v14 container image with Rust 1.54
  • b6858b2 run cargo audit with --deny warnings enabled
  • See full diff in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
gsserge commented 2 years ago

@lauralt do you think it's ok to use #[derive(Default)] for RtcState, or you'd rather prefer to keep the manual Default impl and ignore this particular clippy warning?

lauralt commented 2 years ago

@lauralt do you think it's ok to use #[derive(Default)] for RtcState, or you'd rather prefer to keep the manual Default impl and ignore this particular clippy warning?

I would keep the manual Default so that is more obvious why we have those default values for the registers. It's also consistent with how we define the default for the serial. Thanks for fixing the issues!