Fix some regressions from #170

lauralt commented 2 years ago

Summary of the PR

While testing the virtio-console in vmm-reference, @RaduNiculae noticed that the vm was no longer booting with the latest upstream. This was caused by some bugs introduced in https://github.com/rust-vmm/vm-virtio/pull/170.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

[ ] All commits in this PR are signed (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
[ ] All added/changed functionality has a corresponding unit/integration test.
[ ] Any newly added unsafe code is properly documented.

jiangliu commented 2 years ago

These regression hasn't been caught by the CI tests, so any thoughts to add more unit test cases?

lauralt commented 2 years ago

These regression hasn't been caught by the CI tests, so any thoughts to add more unit test cases?

Yeah, good point. I''ll try to find some time next week, but maybe @uran0sH would be interested in doing that.

rust-vmm / vm-virtio

Fix some regressions from #170 #177

Summary of the PR

Requirements