search

rust-vmm / vm-virtio

virtio implementation
Apache License 2.0
366 stars 87 forks source link

virtio-bindings: regenerate #194

Closed alyssais closed 1 year ago

alyssais commented 2 years ago

Summary of the PR

Here I've regenerated the bindings with modern versions of bindgen, Glibc, and Linux. I put each tool update into its own commit to make it easy to see which upgrade caused which changes.

Something that worries me a little bit is that as part of the update to the kernel headers, some structs have gained members, and virtio_net_hdr_v1 has lost its Debug, Default, and PartialEq implementations due to the addition of a union member. Both of these are technically breaking changes in the Rust sense, even if they're not considered so by the kernel. But they're also minor, so I'm not sure if it makes sense to worry about them? cc @sboeuf

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

alyssais commented 1 year ago

Updated to:

andreeaflorescu commented 1 year ago

@alyssais the build is failing because of some problems with how we were specifying dependencies. Once we merge #202 that shouldn't be a problem anymore.

alyssais commented 1 year ago

Should be all sorted and ready for review. :)

alyssais commented 1 year ago

AFAICT, CI failed because it timed out updating the crates.io index? And also for the same reason as #206, i.e. https://github.com/bheisler/criterion.rs/issues/629.

lauralt commented 1 year ago

AFAICT, CI failed because it timed out updating the crates.io index? And also for the same reason as #206, i.e. bheisler/criterion.rs#629.

Yes, we need to ignore it as we already did here: https://github.com/rust-vmm/linux-loader/commit/2580d45f741988468e9b086adbcadae7cc7433a5.

lauralt commented 1 year ago

And we need to fix and merge the rust-vmm-ci bump, the timeout problem you mentioned is (temporarily) fixed here. I will try to fix this asap, but don't quite have bandwidth today.

andreeaflorescu commented 1 year ago

And we need to fix and merge the rust-vmm-ci bump, the timeout problem you mentioned is (temporarily) fixed here. I will try to fix this asap, but don't quite have bandwidth today.

I did the fix, you can just rebase on top of the main branch and there should be no more failures.