search

rust-vmm / vm-virtio

virtio implementation
Apache License 2.0
364 stars 87 forks source link

virtio-queue: fix endianess issues in mock queue #223

Closed slp closed 1 year ago

slp commented 1 year ago

Fix a couple of new endianess issues in the mock queue that impact big endian hosts (namely, s390x).

Signed-off-by: Sergio Lopez slp@redhat.com

lauralt commented 1 year ago

So, I think that for virtio 1.0 the spec does specify little endian but for legacy/pre 1.0 it is native endian. Does this crate support legacy/transitional devices?

No, it doesn't, it is specified in the first note here.

andreeaflorescu commented 1 year ago

I wonder if we could get the CI running on a big endian host so that we don't introduce these breaking changes all the time :( are there any easy hosts that we could set up?

slp commented 1 year ago

I wonder if we could get the CI running on a big endian host so that we don't introduce these breaking changes all the time :( are there any easy hosts that we could set up?

That would be great, but I'm not aware of any CI service providing s390x support :-(

andreeaflorescu commented 1 year ago

Buildkite allows us to run the CI on any host, we just need a s390x host on which we can install the buildkite agent.