virtio-queue Assertion failure in benches/queue/mod.rs on s390x.

rust-vmm / vm-virtio

virtio implementation

Apache License 2.0

364 stars 87 forks source link

virtio-queue Assertion failure in benches/queue/mod.rs on s390x. #238

Open plugwash opened 1 year ago

plugwash commented 1 year ago

When running "cargo test --bench main --all-features" for the virtio-queue crate (both the version from crates.io and the latest version from git) on s390x, I get.

Testing single chain (indirect=false) thread 'main' panicked at 'assertion failed: (left == right) left: 256, right: 1', crates/virtio-queue/benches/queue/mod.rs:63:17

I presume this is an endian issue as it is not happening on any of the other architectures we test.

lauralt commented 1 year ago

Hi, yeah it is most probably an endianness issue. @slp fixed some of them, see PR, but I am not sure if the benches have been tested as well. We don't have a CI instance for s390x, so the issues on this platform can only be discovered by manual testing.