Closed epilys closed 8 months ago
Rebased against main
.
Rebased against main
.
Looks like the pipeline also needs to be updated as the fuzz tests are now failing. Same for the coverage test.
Got to make sure CI works first...
@andreeaflorescu fixed the CI pipelines now, ready for review.
Should we also update the following lines?
virtio-bindings/CONTRIBUTING.md:56:cp linux/v5_0_headers/*.rs vm-virtio/crates/virtio-bindings/src
virtio-bindings/CONTRIBUTING.md:57:mv vm-virtio/crates/virtio-bindings/src/virtio_net.rs vm-virtio/crates/virtio-bindings/src/virtio_net/generated.rs
virtio-queue/README.md:108:![queue](https://raw.githubusercontent.com/rust-vmm/vm-virtio/main/crates/virtio-queue/docs/images/queue.png)
virtio-queue/README.md:117:![descriptor](https://raw.githubusercontent.com/rust-vmm/vm-virtio/main/crates/virtio-queue/docs/images/descriptor.png)
@stefano-garzarella thanks, fixed! :)
LGTM!
Rebased against main.
Ping
@andreeaflorescu @alexandruag @jiangliu @slp @stsquad
Summary of the PR
Having all the workspace crates under the crates/ directory is unnecessary. Rust documentation itself recommends all crates to be in the root directory:
https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html#creating-the-second-package-in-the-workspace
I paste the text content here, in case the online page ever changes or becomes unavailable:
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.