Closed dependabot[bot] closed 10 months ago
Depends on https://github.com/rust-vmm/vm-virtio/pull/263. Not sure why the coverage tanked though...
Can someone do @dependabot rebase
here?
@dependabot rebase
ValueError: Current code coverage (58.72%) deviates by 30.38% from the previous code coverage 89.10%.Current code coverage must be within the range 89.10%..89.60%.Please update the coverage in
coverage_config_x86_64.json
.
Huh?..
ValueError: Current code coverage (58.72%) deviates by 30.38% from the previous code coverage 89.10%.Current code coverage must be within the range 89.10%..89.60%.Please update the coverage in
coverage_config_x86_64.json
.Huh?..
mmm, strange! Could that be related to https://github.com/rust-vmm/rust-vmm-ci/pull/133 ? @roypat any suggestion?
Considering how big the difference is I don't think is related only to that. I would guess that the tests for some crates are no longer running 🤷♀️ otherwise it doesn't make sense. For the other crates the difference was only a few percentages.
Sorry, I was out sick until today and only saw this now :(
I think its because the exclude_path
in coverage_config_x86_64.json
needs to be updated, the syntax here changed slightly with https://github.com/rust-vmm/rust-vmm-ci/pull/132. Iirc its a regex on the filename now, so maybe changing it to virtio-bindings|mock\.rs
will fix it? :sweat_smile:
`
@roypat good point!
We can also just replace the ,
with |
and it works, something like this:
diff --git a/coverage_config_x86_64.json b/coverage_config_x86_64.json
index bf4b322..5d42b9a 100644
--- a/coverage_config_x86_64.json
+++ b/coverage_config_x86_64.json
@@ -1,5 +1,5 @@
{
"coverage_score": 89.1,
- "exclude_path": "crates/virtio-bindings,crates/virtio-queue/src/mock.rs",
+ "exclude_path": "crates/virtio-bindings|crates/virtio-queue/src/mock.rs",
"crate_features": "virtio-blk/backend-stdio"
}
But we need to fix test_coverage.py
and put the -ignore-filename-regex
argument between double quotes, otherwise it fails. I'll send a patch.
PR here: https://github.com/rust-vmm/rust-vmm-ci/pull/137 When it will be merged, we can ask dependabot to update this PR and I will update the coverage_config files.
@dependabot rebase
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate
.
how do we get it to pick up the new commits from rust-vmm-ci? :thinking:
@dependabot recreate
Superseded by #264.
Bumps rust-vmm-ci from
589b6b1
to9751aaa
.Commits
9751aaa
README: Fix link to setup_new_repo.md665f31f
Add Rust unittest so that test_coverage properly self-tests2148c04
Update container version to 26412ecd5
Have coverage test use llvm-cov instead of cargo-kcov7c1057e
test_commit_format: no longer check body length9dfe5b2
Use derivatives of BaseException for exceptions7e9af57
test: Update code coverage test56bfdc9
test: Format withblack
285971e
Update container version to 24Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show