rust-vmm / vm-virtio

virtio implementation
Apache License 2.0
361 stars 87 forks source link

Update to vm-memory 0.13.1 #261

Closed Ablu closed 10 months ago

Ablu commented 10 months ago

Mostly this introduces the traits WriteVolatile and ReadVolatile. Since these can deal more efficiently deal with the volatile semantics, some old methods got deprecated.

Mostly that means replacing Read/Write with {Read,Write}Volatile.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

epilys commented 10 months ago

@Ablu There are some CI compilation errors, can you check them out?

Ablu commented 10 months ago

@Ablu There are some CI compilation errors, can you check them out?

eh... I built with export RUSTFLAGS="-D warnings"! Will check out what goes wrong...

EDIT: Ah, missed --all-features

Ablu commented 10 months ago

fixed (hopefully).

stefano-garzarella commented 10 months ago

@Ablu looks like we need to update vm-memory also in fuzz/common/Cargo.toml

Ablu commented 10 months ago

Looks like aarch64 fails building since it now has two versions of vm-memory in the dependency tree:

Compiling vm-memory v0.13.1
Compiling vm-memory v0.12.2

Investigating...

Ablu commented 10 months ago

@Ablu looks like we need to update vm-memory also in fuzz/common/Cargo.toml

yeah, looks like my regex somehow missed that... Fixed now.

Ablu commented 10 months ago

Rebased from Github UI