Closed Ablu closed 10 months ago
@Ablu There are some CI compilation errors, can you check them out?
@Ablu There are some CI compilation errors, can you check them out?
eh... I built with export RUSTFLAGS="-D warnings"
! Will check out what goes wrong...
EDIT: Ah, missed --all-features
fixed (hopefully).
@Ablu looks like we need to update vm-memory
also in fuzz/common/Cargo.toml
Looks like aarch64 fails building since it now has two versions of vm-memory in the dependency tree:
Compiling vm-memory v0.13.1
Compiling vm-memory v0.12.2
Investigating...
@Ablu looks like we need to update
vm-memory
also infuzz/common/Cargo.toml
yeah, looks like my regex somehow missed that... Fixed now.
Rebased from Github UI
Mostly this introduces the traits WriteVolatile and ReadVolatile. Since these can deal more efficiently deal with the volatile semantics, some old methods got deprecated.
Mostly that means replacing Read/Write with {Read,Write}Volatile.
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.