Remove hard coded addresses for the RTC and Serial

rust-vmm / vmm-reference

A VMM implementation based of rust-vmm components

Apache License 2.0

146 stars 61 forks source link

Remove hard coded addresses for the RTC and Serial #212

Closed uran0sH closed 2 years ago

uran0sH commented 2 years ago

Summary of the PR

We need this to make devices add dynamically to the FDT.

issue: #126

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

[x] All commits in this PR are signed (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
[x] Any newly added unsafe code is properly documented.

andreeaflorescu commented 2 years ago

LGTM, I don't think we need to add a test for this one at the moment because we have some subsequent changes that are needed. Can you remove the commented lines? Also, it would be nice for the commit message to respond to the question of "why do we need this change?". The answer should be something along the lines of: without this it is not possible to dynamically add devices to the FDT.

uran0sH commented 2 years ago

I use the Builder Pattern to re-implement create_fdt. plz review.

uran0sH commented 2 years ago

I have split the PR. @andreeaflorescu @lauralt