Closed ramyak-mehra closed 2 years ago
This PR is in continuation to a previous PR #227, whose branch was accidentally deleted thus resulting in PR automatically being closed.
@ramyak-mehra can you please add a separate commit to fix the cargo audit
warning? The fix is pretty simple, you just need to update the version of clap
to 3.2.17, which is the latest release. In the commit you need to have both the Cargo.toml
update as well as the Cargo.lock
update.
This is where the version update is needed: https://github.com/rust-vmm/vmm-reference/blob/main/src/api/Cargo.toml#L8
@ramyak-mehra I see some comments are marked as resolved, but not addressed. Are you going to do another push in the near future or what's the plan?
We needed IRQAllocator for adding support for multiple devices. IRQ_NUM for each platform is now passed down through VMConfig. default value are used.
Signed-off-by: Ramyak mehra rmehra_be19@thapar.edu
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following requirements:
git commit -s
), and the commit message has max 60 characters for the summary and max 75 characters for each description line.unsafe
code is properly documented.