Fix panic caused by rand_bytes()

vibharya commented 1 year ago

Signed-off-by: Vibha Acharya vibharya@amazon.co.uk

rand_bytes() causes a panic when number of bytes requested are not multiples of 4. 'main' panicked at 'attempt to subtract with overflow'

Relates to : #178

The unit test was testing for 8 which is why it passed.

Before submitting your PR, please make sure you addressed the following requirements:

[x] All commits in this PR are signed (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
[x] All added/changed functionality has a corresponding unit/integration test.
[x] All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.

andreeaflorescu commented 1 year ago

Can you also add the following to your commit message: Fixes: https://github.com/rust-vmm/vmm-sys-util/issues/178

This way the issue will be closed when we merged the PR and we also trace it back when doing a git log.

andreeaflorescu commented 1 year ago

Please update the changelog to specify the bug you fixed. This is now part of the requirements for a PR.

There is still the changelog update needed.

rust-vmm / vmm-sys-util