search

rust-vmm / vmm-sys-util

Helpers and utilities used by multiple rust-vmm components and VMMs
BSD 3-Clause "New" or "Revised" License
78 stars 64 forks source link

Disable compilation of Atomic64 code in metric.rs if there's no Atomic64 #188

Open mjt0k opened 1 year ago

mjt0k commented 1 year ago

Atomic64 is not present, at least, on armel, mipsel and x32 platforms. Disable compilation of metrics.rs which enhances this data type.

andreeaflorescu commented 1 year ago

@mjt0k can we think about a way to test this in the CI? I find it nice that we're adding support for other platforms as well, but the problem I am seeing is that (similar to the big endian support in vm-virtio) we are going to fix it, and future PRs will break it because we're not testing it.

andreeaflorescu commented 1 year ago

@mjt0k can you fix your commit message so we can merge this? We are expecting the summary to be less than 60 chars, and the body to be less than 72 (i think). We have some issues with the CI (cargo audit is not installed on arm, and that's why it's failing), so we can ignore that for now.