search

rust-windowing / glutin

A low-level library for OpenGL context creation
Apache License 2.0
2k stars 477 forks source link

egl: set context version when egl < 1.5 #1655

Closed kchibisov closed 10 months ago

kchibisov commented 10 months ago

Signed-off-by: p0ryae theporyafm12@gmail.com Fixes #1647.

--

@p0ryae does it fix your issue?

MarijnS95 commented 10 months ago

The commit signoff looks a bit weird, since you (@kchibisov) are both the author and committer.

Perhaps this should be a Reported-by:, Suggested-by:, Tested-by:?

kchibisov commented 10 months ago

Perhaps this should be a Reported-by:, Suggested-by:, Tested-by:?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

kchibisov commented 10 months ago

I guess C-d-b is better.

MarijnS95 commented 10 months ago

Oh yeah I forgot C-d-b, that's best!

p0ryae commented 10 months ago

@p0ryae does it fix your issue?

Yes. Tested the egl-1.3-set-version branch and my tests pass.